[PLUGIN-1721] Added support for timestamp_tz datatype in. snowflake source plugin. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertshau
reviewed
Nov 30, 2023
| | TIMESTAMP_LTZ | timestamp | TIMESTAMP with local time zone; time zone, if provided, is not stored.| | ||
| | TIMESTAMP_NTZ | timestamp | TIMESTAMP with no time zone; time zone, if provided, is not stored.| | ||
| | TIMESTAMP_TZ | string | TIMESTAMP with time zone. | | ||
| | TIMESTAMP_TZ | timestamp | TIMESTAMP with time zone. | |
Contributor
There was a problem hiding this comment.
was this mistakenly in the doc before or was it actually being read as a string?
If it was being read as a string, we can't just change the data type as that will break backwards compatibility.
Contributor
Author
There was a problem hiding this comment.
it was added mistakenly only, was giving validation error on this data type.
src/test/java/io/cdap/plugin/snowflake/common/util/SchemaHelperTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/cdap/plugin/snowflake/common/util/SchemaHelperTest.java
Outdated
Show resolved
Hide resolved
vikasrathee-cs
force-pushed
the
bugfix/timestamptz
branch
from
206cba8 to
3c5cd45
Compare
MrRahulSharma
approved these changes
Dec 4, 2023
added support for timestamp_tz datatype.
vikasrathee-cs
force-pushed
the
bugfix/timestamptz
branch
from
3c5cd45 to
2d4c9e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for timestamp_tz datatype in snowflake plugin.