Conversation
Collaborator
Author
|
force merging because the original restriction made assumptions that do not hold |
Collaborator
Author
|
NOTE: I kiinda snuck this through but I am confident it is safe (or at least, no worse than before): previously the "try it" commands in swagger were hardcoded to localhost:9090, rather than the host the frontend loaded from. This means that accessing the try it functionality required tunneling into whatever machine was running it, even if FE was available. This did not provide any additional safety (can always copy the curl for any endpoint), just inconvenience. Actual security is handled by access gating the API in either case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.