Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions pkg/storage/s3/reader.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
package s3

import (
"io"
)

type CountingReader interface {
io.Reader
Bytes() int64
}

func NewCountingReader(r io.Reader) CountingReader {
return &countingReader{r: r}
}

type countingReader struct {
r io.Reader
bytes int64
}

func (cr *countingReader) Read(p []byte) (int, error) {
n, err := cr.r.Read(p)
cr.bytes += int64(n)
return n, err
}

func (cr *countingReader) Bytes() int64 {
return cr.bytes
}
5 changes: 3 additions & 2 deletions pkg/storage/s3/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ func (s *S3) Push(target, source string, logger *log.Entry) (int64, error) {
return 0, fmt.Errorf("failed to read input file %q, %v", source, err)
}
defer f.Close()
countingReader := NewCountingReader(f)

// S3 always prepends a /, so if it already has one, it would become //
// For some services, that is ok, but for others, it causes issues.
Expand All @@ -122,12 +123,12 @@ func (s *S3) Push(target, source string, logger *log.Entry) (int64, error) {
_, err = uploader.Upload(context.TODO(), &s3.PutObjectInput{
Bucket: aws.String(bucket),
Key: aws.String(key),
Body: f,
Body: countingReader,
})
if err != nil {
return 0, fmt.Errorf("failed to upload file, %v", err)
}
return 0, nil
return countingReader.Bytes(), nil
}

func (s *S3) Clean(filename string) string {
Expand Down
Loading