Skip to content

when reporting logging messages for prune targets, correctly report the target URL #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2024
Merged

when reporting logging messages for prune targets, correctly report the target URL #396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/core/prune.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func (e *Executor) Prune(ctx context.Context, opts PruneOptions) error {

for _, target := range opts.Targets {
if err := pruneTarget(tracerCtx, logger, target, now, retainHours, retainCount); err != nil {
return fmt.Errorf("failed to prune target %s: %v", target, err)
return fmt.Errorf("failed to prune target %s: %v", target.URL(), err)
}
}

Expand Down Expand Up @@ -141,7 +141,7 @@ func pruneTarget(ctx context.Context, logger *logrus.Entry, target storage.Stora
}
pruned++
}
logger.Debugf("pruning %d files from target %s", pruned, target)
logger.Debugf("pruning %d files from target %s", pruned, target.URL())
span.SetStatus(codes.Ok, fmt.Sprintf("pruned %d files", pruned))
return nil
}
Expand Down
Loading