Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for getting current context at any codelocation that runs und… #6

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

jonathanshir
Copy link

@jonathanshir jonathanshir commented Apr 27, 2020

Support for getting current context at any codelocation that runs under the scope of BaseOperator.execute function. This implementation supports apache#8058 AIP31 functional operators


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

airflow/models/taskinstance.py Outdated Show resolved Hide resolved
airflow/models/taskinstance.py Outdated Show resolved Hide resolved
airflow/models/taskinstance.py Outdated Show resolved Hide resolved
@turbaszek
Copy link

Once wmove to Apache we need to provide good description why we do this ;)

@turbaszek turbaszek force-pushed the feature/aip31_current_context branch from 52213d1 to adb7cc4 Compare July 2, 2020 14:30
aneesh-joseph and others added 23 commits July 3, 2020 18:15
Sometimes tests were not triggered when they should be.
This change will cause the tests to be triggered when anything
changes in "airflow" or "charts" additionally to what we had
before.
The script failed on a "clean" installation if the image
required cleaning and the database was not started.
* add git sync sidecars

* add a helm test

* add more tests

* allow users to provide git username and pass via  a k8s secrets

* set default values for airflow worker repository & tag

* change ci timeout

* fix link

* add credentials_secret to airflow.cfg configmap

* set GIT_SYNC_ADD_USER on kubernetes worker pods, set uid

* add fsGroup to webserver and kubernete workers

* move gitSync to dags.gitSync

* rename valueFields

* turn off git sync and dag persistence by default

* provide option to specify known_hosts

* add git-sync details into the chart documentation

* Update .gitignore

Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>

* make git sync max failures configurable

* Apply suggestions from code review

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

* add back requirements.lock

Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Add setUp and tearDown methods to clear tabels
Many of the pre-commits don't require `require_serial: true`. This PR removes those to use the default of `require_serial: false`
* More robust and re-runnable autocomplete setup in Breeze

* Update breeze

Co-authored-by: Tomek Urbaszek <turbaszek@gmail.com>

Co-authored-by: Tomek Urbaszek <turbaszek@gmail.com>
@turbaszek turbaszek force-pushed the feature/aip31_current_context branch from adb7cc4 to de148b0 Compare July 6, 2020 15:13
Support for getting current context at any codelocation that runs
under the scope of BaseOperator.execute function. This functionality
is part of AIP-31
@turbaszek turbaszek force-pushed the feature/aip31_current_context branch from de148b0 to 47b91e0 Compare July 6, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.