Simplify DagBag - remove dead code related to SerializedDag#9676
Merged
mik-laj merged 2 commits intoapache:masterfrom Jul 6, 2020
Merged
Simplify DagBag - remove dead code related to SerializedDag#9676mik-laj merged 2 commits intoapache:masterfrom
mik-laj merged 2 commits intoapache:masterfrom
Conversation
kaxil
changed the title
mik-laj
commented
Jul 5, 2020
airflow/models/dagbag.py
Outdated
Member
Author
There was a problem hiding this comment.
setf.dags.keys returns KeysView. We want to have an non-llive object.
kaxil
approved these changes
Jul 5, 2020
Member
|
@mik-laj Can you please rebase on latest master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.