fix(strings): EN/AR parity for default_notification_channel_id (E01.S06)#5
Open
abdout wants to merge 1 commit into
Open
fix(strings): EN/AR parity for default_notification_channel_id (E01.S06)#5abdout wants to merge 1 commit into
abdout wants to merge 1 commit into
Conversation
`:app:checkStringParity` was failing because the EN strings.xml carried the `default_notification_channel_id = "default"` channel ID with no matching AR entry (47 EN vs 46 AR). The key is a programmatic NotificationChannel identifier, not a user-facing string, so both locales must hold the literal value `default`. Adds the AR entry and an XML comment in both files documenting that this is a channel ID and must not be translated. Verification: `diff <(grep -oE 'name="[^"]+"' values/strings.xml | sort) <(grep -oE 'name="[^"]+"' values-ar/strings.xml | sort)` returns empty. Closes #4 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default_notification_channel_identry tovalues-ar/strings.xmlso:app:checkStringParityis greendefaultvalue in both localesStory
E01.S06 (Phase 1 Pilot v1, Sprint P1, 1 pt) — first pilot story shipped.
Test plan
grep -oE 'name=\"[^\"]+\"' values/strings.xml | sortand same forvalues-ar/strings.xmlare now identical./gradlew :app:checkStringParitypasses on CI (relevant pre-merge gate)Closes #4
Generated with Claude Code