Skip to content

chore: collapse quality vocabulary, delete sweep system, ground self-quality framing#124

Open
abdout wants to merge 6 commits into
mainfrom
chore/quality-vocabulary-cleanup
Open

chore: collapse quality vocabulary, delete sweep system, ground self-quality framing#124
abdout wants to merge 6 commits into
mainfrom
chore/quality-vocabulary-cleanup

Conversation

@abdout
Copy link
Copy Markdown
Contributor

@abdout abdout commented May 28, 2026

Summary

  • Collapse the quality + ship keyword surface to a canonical 6 verbs: /check, /handover, /ship, /watch, /report, /quick
  • Implement two orphans worth keeping — /ship (production deploy) and /handover (Playwright multi-pass QA)
  • Delete the 15-command coverage sweep system (shelfware: every ledger empty, no sweep ever ran end-to-end)
  • Drop the "Full Autopilot (100-turn cycles)" claim — engine is interactive; /handover is the user-triggered self-quality verb

Changes

Added

  • .claude/commands/ship.md — production deploy via Vercel --prod, distinct from /deploy (staging)
  • .claude/commands/handover.md — five-pass headed Playwright QA scoped to a feature block

Removed

  • .claude/coverage/ — the entire sweep protocol + keyword definitions
  • .claude/commands/{nextjs,react,typescript,tailwind,shadcn,accessibility,barrel,prisma,authjs,translate,skeleton,structure,guard,waterfall,coverage}.md (15 files)

Refactored

  • .claude/agents/quality-engineer.md — agent is now a router for 17 niche keywords + 2 orchestrators (qa, /handover). Dropped the ledger / sweep orchestration framing.
  • .claude/CLAUDE.md — three flat sections (Pipeline / Tools / Vocabulary); dropped Tier 2b and "Full Autopilot"
  • Renamed the niche browser keyword checkresponsive to remove collision with the /check pre-ship gate command

Synced docs

  • docs/CONFIGURATION.md — removed Full Autopilot row
  • docs/WORKFLOWS.md — section 1.7 points at .claude/commands/handover.md
  • src/components/docs/spellbook-data.ts/validate orphan replaced with real /check spell; /handover spell added to Defense Against the Dark Arts

Canonical vocabulary

Phase Verb Purpose
Pre-ship /check Typecheck + build + visual + tests
Self-quality /handover Multi-pass Playwright QA before client demo
Ship /ship Production deploy (Vercel --prod)
Post-ship /watch Visual + console + smoke on prod URL
Resolve /report Auto-fix user-reported issues
Iterate /quick fix → commit → push

Test plan

  • grep -rn "Tier 2b\|/verify\|/validate\|Full Autopilot" .claude/ docs/ returns zero active matches
  • ls .claude/commands/ contains ship.md + handover.md, no sweep files
  • ls .claude/coverage/ returns "no such directory"
  • Fresh session: typing /ship triggers the new command; typing /handover admission runs five passes
  • pnpm tsc --noEmit shows no new errors from spellbook-data.ts
  • Published docs at kun.databayt.org/docs/keywords show the canonical vocabulary after deploy

Closes #123

🤖 Generated with Claude Code

abdout and others added 6 commits May 28, 2026 16:10
/ship promotes a /check-passed build to Vercel production. Distinct
from /deploy (staging/preview) — names telegraph the target.

Wraps `npx vercel --prod --yes` with the same 5-attempt auto-fix loop
the deploy skill uses. Refuses dirty working tree; runs /check inline
if not already passed in the session; suggests /watch on success.

Implements the orphan referenced in the /feature pipeline (stage 7).

Refs #123

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Real implementation of the pre-demo quality pass referenced in
docs/WORKFLOWS.md. Five passes per route in a feature block:

1. Bug-free — console + network clean
2. Flow — primary user journey completes
3. Responsive — 375 / 768 / 1440 layouts
4. RTL + i18n — Arabic mirrors, LTR exemptions hold
5. Translation — no hardcoded strings, all keys resolve

Uses browser-headed MCP for visible runs. Outputs a report with
screenshots to .claude/handover-reports/<block>-<timestamp>/.
Supports --fix for translation + RTL automated fixes; flow and
responsive failures stay manual.

This is the "self-quality" verb the engine was missing: user-
triggered, deeper than /check, scoped to a block.

Refs #123

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Delete 15 sweep command files + the .claude/coverage/ directory.

Every ledger has been empty (12 bytes) since the system was designed
in April. No sweep has ever run end-to-end on any product. The
protocol and keyword definitions were thorough but unused — Tier 2b
existed as documentation, not as a live capability.

Removed:
- .claude/coverage/{keywords.json,sweep-protocol.md}
- .claude/commands/{nextjs,react,typescript,tailwind,shadcn,
  accessibility,barrel,prisma,authjs,translate,skeleton,structure,
  guard,waterfall,coverage}.md

Subsequent commits collapse the Tier 2b framing in CLAUDE.md and
strip the sweep orchestration from the quality-engineer agent.

If full-coverage sweeps are wanted later, schedule /handover via
the schedule skill against staging URLs — that path needs zero new
infrastructure.

Refs #123

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…p orchestration

Strip the 5 sweep references (translate, skeleton, structure, guard,
coverage as full-coverage sweeps) and the per-product ledger/health-
monitoring table — none of that ran in practice and the underlying
files were deleted in the previous commit.

What remains is the truthful surface:

- 17 niche keywords across browser (6), code (6), deep (3), compare (2)
- 2 orchestrators: qa (per-URL, 12 checks) and /handover (per-block,
  5-pass Playwright via .claude/commands/handover.md)

The agent is now a router — keyword → MCP/specialist — not a sweep
orchestrator pretending to maintain a ledger.

Refs #123

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…esponsive

Project-level CLAUDE.md rewrite:

- Drop the "Tier 1 / Tier 2 / Tier 2b / Tier 3" mental model. Replace
  with three flat sections — Pipeline, Tools, Vocabulary.
- Remove "Mode: Full Autopilot (100-turn cycles)" — aspirational, no
  autonomous loop exists in the codebase. /handover is the
  user-triggered materialization of self-quality.
- Add /handover to the pipeline narrative as the pre-demo gate.
- Drop the Tier 2b table (sweeps were deleted in a prior commit).
- Rename the niche browser keyword `check` to `responsive` to remove
  the collision with the /check pre-ship gate command. The 17-keyword
  surface in quality-engineer.md is updated to match.

The global ~/.claude/CLAUDE.md keyword vocabulary table also gets a
new Lifecycle row (check, handover, ship, watch, report, quick) — see
that file for the change; it lives outside the repo.

Refs #123

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Spellbook (content/docs):
- Replace the /validate orphan with a real /check spell (the
  pre-ship gate). Update the Nox quote accordingly.
- Add /handover spell in Defense Against the Dark Arts, alongside
  test / e2e / review.
- Fix the build spell's connects: validate → check.
- Sweep keywords (nextjs, react, tailwind, etc.) stay in the
  spellbook — those entries describe framework patterns, not the
  deleted sweep commands.

docs/CONFIGURATION.md:
- Strip the "Full Autopilot (100-turn cycles)" mode row in the
  Layer 1 settings table — engine is interactive, not autonomous.

docs/WORKFLOWS.md:
- Point section 1.7 (Handover QA) at the new command file and
  the report output directory. Aligns the documented passes with
  the implemented spec.

Verified: pnpm tsc --noEmit introduces zero new errors from
these edits (existing layout + mdx-components type issues
predate this PR).

Closes #123

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: collapse quality vocabulary, delete sweep system, ground self-quality framing

1 participant