Skip to content

fix(ts): dictionary type drift (Class 3)#14

Open
abdout wants to merge 1 commit into
mainfrom
chore/ts-class3-dict-drift
Open

fix(ts): dictionary type drift (Class 3)#14
abdout wants to merge 1 commit into
mainfrom
chore/ts-class3-dict-drift

Conversation

@abdout
Copy link
Copy Markdown
Contributor

@abdout abdout commented Apr 25, 2026

Summary

Changes

  • `src/components/example/internationalized-content.tsx` — map `hero.cta`/`hero.learnMore` to existing keys (`appointment`/`services`). Demo file, never imported elsewhere.
  • `src/components/marketing/content.tsx` — drop unused `dictionary`/`params` props from ``, ``, ``, ``. Each of these reads i18n via `useTranslations()` directly.

Test plan

  • /en and /ar marketing landing render all sections (FeatureCards, Parallax, Ready, Stack, ReadyToBuildSection)
  • No console warnings about unknown props

Follow-ups

Remaining classes:

  • Class 5 (LayoutProps) — after fix(auth): restore SessionProvider in [lang]/layout #10 merges
  • Class 2 (`User.username` schema drift, 8 errors) — needs your decision: restore `username` field or migrate code to `name`?
  • Class 1 (12 dead imports from `@/components/platform/`, `@/components/onboarding/`, `@/components/invoice/`, `@/components/atom/modal`, `@react-email/components`) — needs per-feature decisions

Closes #13

🤖 Generated with Claude Code

Six TS errors from stale dict references and prop drilling:

- example/internationalized-content.tsx: t.marketing.hero.cta and
  .learnMore don't exist; map to the actual hero keys
  (appointment, services)
- marketing/content.tsx: FeatureCards, Parallax, Stack, and
  ReadyToBuildSection are prop-less components that read i18n via
  useTranslations() internally — drop the dictionary/params props.
  Ready is left unchanged (it does accept those props).

Closes #13

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marketing Ready Ready Preview, Comment Apr 25, 2026 9:42am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ts): dictionary type drift in marketing/content + example (Class 3)

1 participant