chore: support more dsn schemes and presign hosts#761
Merged
everpcpc merged 1 commit intodatabendlabs:mainfrom Mar 20, 2026
Merged
chore: support more dsn schemes and presign hosts#761everpcpc merged 1 commit intodatabendlabs:mainfrom
everpcpc merged 1 commit intodatabendlabs:mainfrom
Conversation
Relax flight protocol detection to accept any scheme ending with +flight instead of hardcoding databend+flight. Add tidbcloud.com to the presign auto-detection host list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relax DSN scheme parsing so the flight protocol detection works with any
+flightsuffix, not justdatabend+flight. Also add a new cloud host to the presign auto-detection list.