Skip to content

Conversation

@everpcpc
Copy link
Member

@everpcpc everpcpc commented Nov 7, 2025

No description provided.

@vercel
Copy link

vercel bot commented Nov 7, 2025

@everpcpc is attempting to deploy a commit to the Databend Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Nov 7, 2025 10:20am

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

4. 在 Databend Cloud 工作区或 `BendSQL` 中执行以下 SQL 语句:
```sql
CREATE CONNECTION databend_test STORAGE_TYPE = 's3' ROLE_ARN = 'arn:aws:iam::987654321987:role/databend-test';

P1 Badge Include EXTERNAL_ID when role trust requires it

The trust policy example now enforces sts:ExternalId ("Condition": { "StringEquals": { "sts:ExternalId": "my-external-id-123" }}), but the connection creation SQL below still omits the EXTERNAL_ID parameter. When the role’s policy requires an external ID, CREATE CONNECTION ... ROLE_ARN = ... without EXTERNAL_ID will fail with AccessDenied because the assume-role call does not supply the required external ID. The sample should either show how to obtain the external ID and pass it (for example EXTERNAL_ID = 'my-external-id-123') or remove the condition. As written, following the instructions will not work.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@everpcpc everpcpc marked this pull request as draft November 7, 2025 10:19
@everpcpc everpcpc marked this pull request as ready for review November 7, 2025 10:19
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@everpcpc everpcpc merged commit 409a32e into databendlabs:main Nov 7, 2025
3 checks passed
@everpcpc everpcpc deleted the fix-cn branch November 7, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant