Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@wolfv
Copy link

@wolfv wolfv commented Mar 10, 2023

No description provided.

@BohuTANG BohuTANG requested a review from hantmac March 10, 2023 23:39
@hantmac
Copy link
Member

hantmac commented Mar 11, 2023

@wolfv Thanks for your contribution! Could you describe the specific problem that you encountered? There already has a generator for long-running queries which will query pages until next_uri is None. The code you can check here https://github.com/databendcloud/databend-py/blob/main/databend_py/client.py#L39.

Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I found the problem. There has a situation: the data in the query process may be empty, but the next_uri is not empty. So we fetch pages until the next_url is None. You can the the bug-fix in this pr

@wolfv
Copy link
Author

wolfv commented Mar 11, 2023

Sorry I wasn't explaining the issue very well! I have a long running query and I got some empty results. I checked and I can get results after calling the next uri

@hantmac
Copy link
Member

hantmac commented Mar 12, 2023

Yes, #7 this pr fix the bug. So I close this pr and open it anytime if you have any question.

@hantmac hantmac closed this Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants