Skip to content

fix(query): fix insert nested data types with expr #10529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2023
Merged

fix(query): fix insert nested data types with expr #10529

merged 2 commits into from
Mar 13, 2023

Conversation

@b41sh
Copy link
Member

@b41sh b41sh commented Mar 13, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Pop values from the inner columns if found error to avoid duplicate values.
  • Rollback reader to start position of the row if need a fallback

Closes #10486

@b41sh b41sh requested review from andylokandy and sundy-li March 13, 2023 10:04
@vercel
Copy link

vercel bot commented Mar 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Mar 13, 2023 at 4:13PM (UTC)

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Mar 13, 2023
@b41sh b41sh force-pushed the fix-insert-nested branch from b705c6f to 765c7ee Compare March 13, 2023 10:40
@b41sh b41sh force-pushed the fix-insert-nested branch from 765c7ee to 48eb1b6 Compare March 13, 2023 11:34
@BohuTANG
Copy link
Member

BohuTANG commented Mar 13, 2023 

05_02_02_csv_spaces:                                                    [ FAIL ] - result differs with:
--- /runner/_work/databend/databend/tests/suites/1_stateful/05_formats/05_02_csv/05_02_02_csv_spaces.result	2023-03-13 12:10:05.289918284 +0000
+++ /runner/_work/databend/databend/tests/suites/1_stateful/05_formats/05_02_csv/05_02_02_csv_spaces.stdout	2023-03-13 12:14:42.480366142 +0000
@@ -1,4 +1,4 @@
  abc 	xyz
  "abc" 	xyz
-1
+0
 1

@b41sh b41sh force-pushed the fix-insert-nested branch from 5dcc243 to 9aaaa2d Compare March 13, 2023 16:12
@BohuTANG BohuTANG merged commit 61f108a into databendlabs:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sundy-li sundy-li sundy-li approved these changes

+1 more reviewer

@andylokandy andylokandy andylokandy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: nested data types insert values need cast cause failed or wrong values

4 participants

@b41sh @BohuTANG @sundy-li @andylokandy