Skip to content

Conversation

@zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Mar 14, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

chore(query): use num_cpu as default_max_storage_io_requests

Closes #issue

@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Mar 14, 2023 at 3:17AM (UTC)

@zhang2014 zhang2014 requested review from BohuTANG and sundy-li March 14, 2023 03:17
@zhang2014 zhang2014 marked this pull request as ready for review March 14, 2023 03:17
@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2023

This pull request's title is not fulfill the requirements. @zhang2014 please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@Xuanwo Xuanwo changed the title chore(query) use num_cpu as default_max_storage_io_requests chore(query): use num_cpu as default_max_storage_io_requests Mar 14, 2023
@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 14, 2023
@zhang2014
Copy link
Member Author

We should recommend user unset max_storage_io_requests in the change log. CC: @PsiACE @soyeric128

@BohuTANG BohuTANG merged commit 83215be into databendlabs:main Mar 14, 2023
@soyeric128
Copy link
Contributor

I don't get it. Is it about the setting max_storage_io_requests? Under what circumstances the setting needs a reset?

@zhang2014
Copy link
Member Author

I don't get it. Is it about the setting max_storage_io_requests? Under what circumstances the setting needs a reset?

The user may have set this setting in a previous version. we might recommend that users unset this setting in the change log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants