fix: join binder stack overflow #10555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Member
|
Need tests to cover the overflow case. |
Contributor
|
I don't think this is a good solution to the issue since it will still fail with a right-deep tree. It's better to introduce a flattened format of join node if you are sticking with this approach. Maybe you can try to reduce the size of the future to make it possible to recurse more times. Just as #6480 did, which won't introduce any logical modification. |
xudong963
force-pushed
the
fix_join_stackoverflow
branch
from
e38759d to
8fa4f3d
Compare
Contributor
Author
Contributor
Author
|
Seems stackoverflow at another position when running under cluster |
Contributor
Author
|
Let's move to a new issue to track cluster stackoverflow: #10585 |
leiysky
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
Closes #10523