Skip to content

Conversation

@TCeason
Copy link
Collaborator

@TCeason TCeason commented Mar 14, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Add the NULLABLE field to information_schema.columns

1 means is_nullable = 'YES'.

0 means is_nullable = 'NO'.

Closes #10557

@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Mar 14, 2023 at 0:07AM (UTC)

@TCeason TCeason requested review from BohuTANG and hantmac March 14, 2023 12:01
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Mar 14, 2023
@hantmac
Copy link
Member

hantmac commented Mar 14, 2023

The comment is wrong, 0 means is_nullable = 'NO'. 😄

@hantmac
Copy link
Member

hantmac commented Mar 14, 2023

@BohuTANG Would u like to help me merge this pr? So that I can use the release tomorrow.

Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@BohuTANG BohuTANG merged commit 1ee3508 into databendlabs:main Mar 14, 2023
@BohuTANG
Copy link
Member

@BohuTANG Would u like to help me merge this pr? So that I can use the release tomorrow.

This patch in the nightly release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add the NULLABLE field to information_schema.columns

3 participants