fix: skip errors on listing tables in admin api #10957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
flaneur2020
force-pushed
the
check-tables-infor
branch
3 times, most recently
from
d4a8646 to
76e7040
Compare
flaneur2020
force-pushed
the
check-tables-infor
branch
from
76e7040 to
989ee02
Compare
lichuang
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
On accessing the tables info by admin api, I got a UnknownShareEndpoint error like this:
Afeter investigation, I found that "default" tenant tries to access a shared database from tenant tncy3exa1, but the share endpoint endpoint is not set. A bad config on one database made all the databases infomation can not be shown at all.
This PR added a
warningsfield in the list_tenant_tables_handler, to swallow the errors but display them in the warnings field. So users can still get the most of table infomations and warning message without lose all the things by one bad config.