Skip to content

Conversation

@sundy-li
Copy link
Member

@sundy-li sundy-li commented Apr 10, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Closes #10985

@vercel
Copy link

vercel bot commented Apr 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2023 3:06pm

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2023

This pull request's title is not fulfill the requirements. @sundy-li please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@sundy-li sundy-li changed the title improve(query): make embedding_vector returns default if not valid chore(query): make embedding_vector returns default if not valid Apr 10, 2023
@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 10, 2023
@zhyass
Copy link
Member

zhyass commented Apr 10, 2023

Can link with the issue #10985?

@BohuTANG BohuTANG merged commit bb6b830 into databendlabs:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: function in update will eval for all rows

3 participants