fix(query): reduce redundant result-set-spill logs during query waits #18741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During long-running SQL queries, the system repeatedly logs empty pages with rows=0 which creates excessive log noise. This change only logs non-empty pages and final completion status. Changes: - Skip logging empty pages (rows=0) during query execution - Only log when pages contain actual data (rows>0) - Log final completion status when query ends with empty page - Preserve all error and cleanup logs for debugging This significantly reduces log volume while maintaining visibility into actual data processing and query completion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
During long-running SQL queries, the HTTP query handler repeatedly logs empty pages with
rows=0, creating excessive log noise. This PR addresses the issue by only logging meaningful events.Tests
Type of change
This change is