Skip to content

fix(query): reduce redundant result-set-spill logs during query waits #18741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BohuTANG merged 1 commit into from
Sep 18, 2025
Merged

fix(query): reduce redundant result-set-spill logs during query waits #18741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/query/service/src/servers/http/v1/query/page_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,20 @@ impl PageManager {
let duration_ms = start_time.elapsed().as_millis();

log::debug!(num_row, wait_type:? = wait; "collect_new_page");
log::info!(
target: "result-set-spill",
"[RESULT-SET-SPILL] Page received page_no={}, rows={}, total_rows={}, end={}, duration_ms={}",
self.total_pages, num_row, self.total_rows + num_row, end, duration_ms
);

if num_row == 0 {
// Only log non-empty pages to avoid spam during long SQL waits
if num_row > 0 {
log::info!(
target: "result-set-spill",
"[RESULT-SET-SPILL] Page received page_no={}, rows={}, total_rows={}, end={}, duration_ms={}",
self.total_pages, num_row, self.total_rows + num_row, end, duration_ms
);
} else if end {
// Only log empty page when query ends
log::info!(
target: "result-set-spill",
"[RESULT-SET-SPILL] Empty page page_no={}, end={}",
self.total_pages, end
"[RESULT-SET-SPILL] Query completed with empty final page page_no={}, total_rows={}",
self.total_pages, self.total_rows
);
}

Expand Down
Loading