Skip to content

Conversation

@zhyass
Copy link
Member

@zhyass zhyass commented Oct 21, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This pull request fixes a bug in the “ANALYZE TABLE” logic where the code could attempt to access a block entry by an offset that is out of range (index out of bounds) because the block reader uses a projected column list, but the code uses an original field index. The fix ensures that the correct offset is used when retrieving block entries and prevents the out-of-bounds panic.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 21, 2025
@zhyass zhyass requested review from dantengsky and sundy-li October 21, 2025 14:57
@github-actions
Copy link
Contributor

🤖 CI Job Analysis

Workflow: 18687642258

📊 Summary

  • Total Jobs: 83
  • Failed Jobs: 2
  • Retryable: 0
  • Code Issues: 2

NO RETRY NEEDED

All failures appear to be code/test issues requiring manual fixes.

🔍 Job Details

  • linux / sqllogic / standalone (base, 2c8g, hybrid): Not retryable (Code/Test)
  • linux / sqllogic / cluster (base, 2c8g, 2, hybrid): Not retryable (Code/Test)

🤖 About

Automated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed).

@BohuTANG BohuTANG merged commit a90032a into databendlabs:main Oct 21, 2025
84 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: analyze table get panic

2 participants