Skip to content

Conversation

@zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Nov 20, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor(query): remove potential performance hotspots caused by fetch_add

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test ci-cloud Build docker image for cloud test labels Nov 20, 2025
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 20, 2025
@zhang2014 zhang2014 removed the ci-benchmark Benchmark: run all test label Nov 20, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-18995-5a0faaf-1763631195

note: this image tag is only available for internal use.

@zhang2014 zhang2014 requested a review from KKould November 20, 2025 10:22
@zhang2014 zhang2014 marked this pull request as ready for review November 20, 2025 10:22
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@zhang2014
Copy link
Member Author

before:
img_v3_02s7_f755ac1e-b908-44f9-a4e7-2c5d2a70e9dg
after:
img_v3_02s7_4cbeace8-bea4-4338-9017-153990f3eeag

@BohuTANG BohuTANG merged commit 986dada into databendlabs:main Nov 20, 2025
167 of 170 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cloud Build docker image for cloud test pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants