-
Notifications
You must be signed in to change notification settings - Fork 837
refactor(query): decrease call tzdb parse #19004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
tests/sqllogictests/suites/query/functions/02_0012_function_datetimes_tz.test
Outdated
Show resolved
Hide resolved
05c127b to
05ce932
Compare
05ce932 to
0500389
Compare
- add the databend-common-timezone crate and bump jiff to 0.2.16 so the workspace shares a single LUT-backed converter - use the new helpers inside IO parsing, expression utilities, timestamp scalars, and age() to preserve offsets/DST behaviour even for pre-1970 dates - expand SQLLogic/unit coverage plus add a datetime_fast_path bench
0500389 to
302d5ad
Compare
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
resolution across DST gaps.
Benchmarks
In PR:
In Main:
Tests
Type of change
This change is