Skip to content

Conversation

@forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Nov 21, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Avoid repeatedly constructing new aggregate evaluators for each row.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 21, 2025
@forsaken628 forsaken628 added the ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits label Nov 24, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-19005-7f1befd-1763957818

note: this image tag is only available for internal use.

@github-actions
Copy link
Contributor

@forsaken628
Copy link
Collaborator Author

benchmark

sql

select array_count(array_append(a,number)) from numbers(10000000),(values([1,2])) t(a) IGNORE_RESULT ;

before:

version: Databend Query v1.2.844-nightly-087c873da4(rust-1.88.0-nightly-2025-11-18T06:41:30.765750122Z)
size: Xsmall
duration: 1.7s

after:

version: Databend Query v1.2.848-nightly-7f1befd26e(rust-1.88.0-nightly-2025-11-24T03:51:53.804747504Z)
size: Xsmall
duration: 383ms

@forsaken628 forsaken628 changed the title refactor(func): array_func refactor(func): optimize function array_aggregate Nov 24, 2025
@forsaken628 forsaken628 marked this pull request as ready for review November 24, 2025 07:34
@sundy-li sundy-li merged commit 5bc4a5d into databendlabs:main Nov 25, 2025
93 checks passed
@forsaken628 forsaken628 deleted the array_func branch November 25, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants