Skip to content

Conversation

@SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Nov 21, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Remove the redundant xxhash; bloom_hash() provides a sufficiently fair hash distribution.

╭────────────────────────────────────────────────────────────────────────────────────────────╮
│ query_id │      v847_time      │      pr_time      │        diff_s       │       ratio_percent       │
│  String  │  Nullable(Float64) │  Nullable(Float64) │ Nullable(Float64) │ Nullable(Float64) │
├──────────┼────────────────────┼────────────────────┼───────────────────┼───────────────────┤
│ q21      │ 108.2450027465820388.59249877929688-19.65-18.16 │
│ q7       │  37.4770011901855527.773500442504883-9.7-25.89 │
│ q9       │  81.9879989624023475.70199966430664-6.29-7.67 │
│ q20      │  18.4360008239746112.978000164031982-5.46-29.61 │
│ q10      │ 49.18399810791015644.983999252319336-4.2-8.54 │
│ q14      │  20.3859996795654316.476499557495117-3.91-19.18 │
│ q8       │ 30.20100021362304726.677000045776367-3.52-11.67 │
│ q12      │ 19.04899978637695317.125999450683594-1.92-10.1 │
│ q17      │  18.4209995269775416.751500129699707-1.67-9.06 │
│ q5       │ 26.94199943542480525.708499908447266-1.23-4.58 │
│ q4       │ 35.19100189208984434.23499870300293-0.96-2.72 │
│ q3       │  43.2350006103515642.58300018310547-0.65-1.51 │
│ q11      │ 3.91100001335144043.668500065803528-0.24-6.2 │
│ q6       │  9.0729999542236338.922000408172607-0.15-1.66 │
│ q1       │ 14.44900035858154314.317500114440918-0.13-0.91 │
│ q18      │  98.8870010375976698.77449798583984-0.11-0.11 │
│ q2       │   6.280000209808356.209499835968018-0.07-1.12 │
│ q16      │  4.5869998931884774.7844998836517330.24.31 │
│ q19      │ 17.41099929809570317.6925001144409180.281.62 │
│ q13      │             42.37543.505500793457031.132.67 │
│ q15      │ 14.85999965667724616.0424995422363281.187.96 │
│ q22      │ 7.21299982070922858.4314997196197511.2216.89 │
╰────────────────────────────────────────────────────────────────────────────────────────────╯

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Nov 21, 2025
@SkyFan2002 SkyFan2002 added ci-cloud Build docker image for cloud test and removed pr-feature this PR introduces a new feature to the codebase labels Nov 21, 2025
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Nov 21, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-19006-51b9bc2-1763711665

note: this image tag is only available for internal use.

@SkyFan2002 SkyFan2002 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Nov 21, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-19006-465c891-1763735531

note: this image tag is only available for internal use.

@SkyFan2002 SkyFan2002 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Nov 24, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-19006-8000b05-1763954575

note: this image tag is only available for internal use.

@SkyFan2002 SkyFan2002 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Nov 24, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-19006-a6aa6c6-1763984150

note: this image tag is only available for internal use.

@SkyFan2002 SkyFan2002 force-pushed the improve_runtime_filter_3 branch from 36f5484 to 1659bcc Compare November 25, 2025 04:50
@SkyFan2002 SkyFan2002 marked this pull request as ready for review November 25, 2025 05:18
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@zhang2014 zhang2014 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Nov 25, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-19006-8d922b9-1764051344

note: this image tag is only available for internal use.

@SkyFan2002
Copy link
Member Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@BohuTANG BohuTANG added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Nov 25, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-19006-e1b5076-1764064013

note: this image tag is only available for internal use.

@BohuTANG
Copy link
Member

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@zhang2014 zhang2014 merged commit 6a78ba1 into databendlabs:main Nov 26, 2025
247 of 253 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants