Skip to content

Conversation

@TCeason
Copy link
Collaborator

@TCeason TCeason commented Nov 26, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Added native DateType ± IntervalType -> DateType overloads so pure date math no longer casts through timestamp and reuses the existing day/month evaluators.
  • Taught the binder to inspect interval literals when binding +/-: if the interval has no time component we keep the date overload, otherwise we auto-cast to the timestamp overload

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason TCeason marked this pull request as draft November 26, 2025 02:18
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Nov 26, 2025
@TCeason TCeason requested review from KKould and sundy-li November 26, 2025 09:34
@TCeason TCeason marked this pull request as ready for review November 26, 2025 09:35
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

- Added native DateType ± IntervalType -> DateType overloads so pure date math no longer casts through timestamp and reuses the existing day/month evaluators.
- Taught the binder to inspect interval literals when binding +/-: if the interval has no time component we keep the date overload, otherwise we auto-cast to the timestamp overload
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@TCeason TCeason merged commit 2f0a820 into databendlabs:main Nov 27, 2025
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants