♻️ Deduplicate log primitives and MCP tool result boilerplate#76
Merged
renardeinside merged 2 commits intomainfrom Feb 16, 2026
Merged
♻️ Deduplicate log primitives and MCP tool result boilerplate#76renardeinside merged 2 commits intomainfrom
renardeinside merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogAggregator,AggregatedRecord,should_skip_log,get_aggregation_key,source_label) toapx-commonso both CLI and MCP use the same codeeffective_timestamp_ms()andsource_label()methods onLogRecord, replacing 6 inline timestamp fallback calculations and 3 duplicated service-name mappingsLogAggregatorto return structuredAggregatedRecordinstead of pre-formatted strings, eliminatingparse_formatted_log_line()round-tripquery_filtered_logs()helper to deduplicate setup betweenfetch_logsandfetch_logs_structuredToolResult::from_serializable()andstructured_error(), replacing 6 identical serialize-or-error patterns in MCP serverRefreshOpenapiArgs(identical toEmptyArgs)Test plan
cargo test --workspace— all 151 tests passjust fmt— no formatting issuesjust check— cargo check, clippy, ruff, prettier all pass🤖 Generated with Claude Code