feat(appkit): add FunctionTool, HostedTool types and MCP client#283
Draft
MarioCadenas wants to merge 1 commit intoagent/1-shared-types-adaptersfrom
Draft
feat(appkit): add FunctionTool, HostedTool types and MCP client#283MarioCadenas wants to merge 1 commit intoagent/1-shared-types-adaptersfrom
MarioCadenas wants to merge 1 commit intoagent/1-shared-types-adaptersfrom
Conversation
3 tasks
MarioCadenas
force-pushed
the
agent/1-shared-types-adapters
branch
from
0e37aea to
71187f9
Compare
MarioCadenas
force-pushed
the
agent/2a-tool-types-mcp
branch
from
f738138 to
629d5c2
Compare
Add explicit tool type definitions and a lightweight MCP client:
- FunctionTool: user-defined tools with JSON Schema parameters + execute
- HostedTool: Genie, VectorSearch, custom/external MCP endpoint configs
- AppKitMcpClient: zero-dependency JSON-RPC 2.0 client over HTTP fetch
- Type guards (isFunctionTool, isHostedTool) and definition converters
- resolveHostedTools maps HostedTool configs to MCP endpoint URLs
- Test coverage for type guards, definition builders, and URL resolution
Also add ergonomic helpers for defining tools at the app layer:
- tool(): Zod-powered factory for function tools. Generates JSON Schema
via z.toJSONSchema(), infers execute() arg types from the schema, and
wraps execution with safeParse so invalid args return an LLM-friendly
error string instead of throwing.
- mcpServer(name, url): concise factory for custom MCP server tools,
replacing the verbose { type, custom_mcp_server: { app_name, app_url } }
wrapper.
- Promote zod from optional peer dep to runtime dep (^4.0.0) so tool()
and z.toJSONSchema() are always available.
Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
MarioCadenas
force-pushed
the
agent/2a-tool-types-mcp
branch
from
629d5c2 to
aa77cbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 2 of 5 (2a) in the agent plugin stack.
FunctionTool: user-defined tools with JSON Schema + execute callbackHostedTool: union of Genie, VectorSearch, custom MCP, and external connection configsAppKitMcpClient: minimal JSON-RPC 2.0 client using raw fetch (zero deps)isFunctionTool,isHostedTool) and definition convertersresolveHostedToolsmaps HostedTool configs to Databricks MCP endpoint URLsPR Stack
Test plan