Skip to content

fix: add name field to genie manifest for non-interactive --set support#384

Merged
pkosiec merged 1 commit into
mainfrom
pkosiec/fix-genie-non-interactive
May 13, 2026
Merged

fix: add name field to genie manifest for non-interactive --set support#384
pkosiec merged 1 commit into
mainfrom
pkosiec/fix-genie-non-interactive

Conversation

@pkosiec
Copy link
Copy Markdown
Member

@pkosiec pkosiec commented May 13, 2026

Summary

  • Adds name field to the genie plugin manifest (fields object) alongside the existing id field
  • Updates both the per-plugin manifest and the template appkit.plugins.json

Problem

databricks apps init --set 'genie.genie-space.name=<value>' fails with:

Error: plugin "genie" has no resource with key "genie-space" and field "name"

The CLI's --set validation checks fields against the AppKit manifest, which only declared id for genie spaces. However, the CLI generator needs both id and name to produce valid DABs genie_space YAML.

Every other multi-field plugin (lakebase/postgres, secret, database) already declares all its fields in the manifest. Genie was the only one missing a field.

Testing

Before (reproduce the bug on main)

# Non-interactive: fails with "has no resource with key "genie-space" and field "name""
dbx apps init --name test-app --features genie \
  --set 'genie.genie-space.id=SPACE123' \
  --set 'genie.genie-space.name=My Space' \
  --run none --deploy=false

After (verify with this branch)

# Non-interactive with both fields: should succeed
dbx apps init --name test-app --features genie \
  --template /path/to/this/branch/template \
  --set 'genie.genie-space.id=SPACE123' \
  --set 'genie.genie-space.name=My Space' \
  --run none --deploy=false

# Non-interactive with only id: should error with "incomplete resource"
dbx apps init --name test-app --features genie \
  --template /path/to/this/branch/template \
  --set 'genie.genie-space.id=SPACE123' \
  --run none --deploy=false

# Interactive: should show Genie Space picker and complete normally
dbx apps init --features genie \
  --template /path/to/this/branch/template

This pull request and its description were written by Isaac.

The CLI `apps init --set genie.genie-space.name=<value>` was rejected
because the genie manifest only declared `id`. The CLI generator needs
both `id` and `name` for valid DABs genie_space YAML. Every other
multi-field plugin already declares all its fields in the manifest.

Co-authored-by: Isaac
@pkosiec pkosiec marked this pull request as ready for review May 13, 2026 15:06
@pkosiec pkosiec requested a review from a team as a code owner May 13, 2026 15:06
@pkosiec pkosiec requested a review from MarioCadenas May 13, 2026 15:06
@pkosiec pkosiec merged commit 7adcec0 into main May 13, 2026
11 checks passed
@pkosiec pkosiec deleted the pkosiec/fix-genie-non-interactive branch May 13, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants