fix(appkit): use retry client for Lakebase V1 transaction retry#393
Open
fallintoplace wants to merge 1 commit into
Open
fix(appkit): use retry client for Lakebase V1 transaction retry#393fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
0f5a8c1 to
8cc8261
Compare
8cc8261 to
cf38613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BEGINandCOMMITafter credential rotationRoot Cause
The auth retry path opened a retry client and passed it to the transaction callback, but still ran transaction boundaries on the original client after releasing it. That could put callback work and transaction control on different clients, or fail because the original client was already released.
Validation
pnpm exec vitest run packages/appkit/src/connectors/tests/lakebase-v1.test.tspnpm exec biome check packages/appkit/src/connectors/lakebase-v1/client.ts packages/appkit/src/connectors/tests/lakebase-v1.test.tspnpm --filter @databricks/appkit typecheckgit diff --checkCloses #392