Fix link markdown used by the doc builds in annotations.yml #2579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliacrawf-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
juliacrawf-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
juliacrawf-db
requested review from
denik and
ilyakuz-db
and removed request for
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
denik
approved these changes
Mar 27, 2025
ilyakuz-db
approved these changes
Mar 27, 2025
Contributor
There was a problem hiding this comment.
Nice! Could you please run make schema to fix failing checks?
Also if you could wait for this PR it will strip all deprecated fields that started to appear recently in docs
Update: it's merged, you can pull updates
juliacrawf-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
juliacrawf-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
annotations.yml is used by the bundle docgen tool to generate Markdown files for the docs site. But since our recent migration, the markdown for links with dynamically generated link text needs to have the underscore escaped.
Tests
Peer review, testing the generated *.md in a docs PR: https://github.com/databricks-eng/universe/pull/987364