acc: Do env var substitution in EnvMatrix values#2678
Merged
Conversation
…ubstitution order
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
andrewnester
approved these changes
Apr 8, 2025
pietern
reviewed
Apr 8, 2025
| parts := strings.SplitN(e, "=", 2) | ||
| if len(parts) == 2 { | ||
| key, val := parts[0], parts[1] | ||
| re := regexp.MustCompile(`\$` + key + `\b`) |
Contributor
There was a problem hiding this comment.
I suspect you need \b to avoid replacing $FOO first and failing to replace $FOOBAR second.
Could you include a comment clarifying this? I was puzzled until I realized this is for overlapping names.
kanterov
pushed a commit
that referenced
this pull request
Apr 8, 2025
## Changes When a $VAR reference is used in value of EnvMatrix, it'll be replaced with its value if there is such variable previously defined. ## Why It's useful to define variables in terms of other variables. For example you can define "$MYCLI=$CLI --someparam". I'm using it to define CLI command that either runs from bundle root or another directory. ## Tests Unit tests + acceptance test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When a $VAR reference is used in value of EnvMatrix, it'll be replaced with its value if there is such variable previously defined.
Why
It's useful to define variables in terms of other variables. For example you can define "$MYCLI=$CLI --someparam". I'm using it to define CLI command that either runs from bundle root or another directory.
Tests
Unit tests + acceptance test.