refactor: use with statement for file reading#2740
Merged
denik merged 2 commits intodatabricks:mainfrom May 7, 2025
Merged
Conversation
allrob23
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
Contributor
|
Hi @allrob23 ! Thanks for your contribution. First-time contributors are required to sign CLA in order for their change to be accepted. If this is something you're willing to do, please reach out to dabs-feedback@databricks.com and we'll take it from there. Thank you! |
Contributor
Author
|
Hi @andrewnester, I just sent the email. |
Contributor
Author
|
Hi @andrewnester, just dropping by to let you know that I signed the CLA |
andrewnester
approved these changes
May 6, 2025
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates the file reading logic to use a with statement, aligning with Python best practices for resource management. is a minor change but ensures consistency with the project standard, as other parts already use with statements.