Improve error when target override fails #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
commented
Apr 23, 2025
| } { | ||
| if root, err = mergeField(root, target, f); err != nil { | ||
| return err | ||
| return fmt.Errorf("failed to merge target=%s field=%s: %w", name, f, err) |
Contributor
Author
There was a problem hiding this comment.
this and above error remain uncovered, I don't know an easy way to trigger it, but it is still worth having context in the error IMO.
Contributor
There was a problem hiding this comment.
I believe it is unreachable code because the configuration is normalized before merging. That means the types match up and merging cannot fail. Still good to include the context in case this assumption changes.
pietern
approved these changes
Apr 24, 2025
| } { | ||
| if root, err = mergeField(root, target, f); err != nil { | ||
| return err | ||
| return fmt.Errorf("failed to merge target=%s field=%s: %w", name, f, err) |
Contributor
There was a problem hiding this comment.
I believe it is unreachable code because the configuration is normalized before merging. That means the types match up and merging cannot fail. Still good to include the context in case this assumption changes.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add prefixes with context for errors in target override.
Why
Saw an error that looks like
The error was caused by some other breaking changes, so I don't have a test, but still, if users ever see that it's not very helpful (e.g. path does not refer to file system but it is related to dyn.Value).
Tests
Existing tests.