Merged
Conversation
02fcd1c to
9499abf
Compare
Contributor
|
Do we need this for the local server? Does this speed up test runs? All handlers that do not have a delay configured should return very fast. There seems to only be one test configured with a delay ( |
Contributor
Author
I expanded justification. This enables a few things but does not give a speed up on the current test suite. |
9499abf to
4142907
Compare
4142907 to
7796058
Compare
shreyas-goenka
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
This makes use of testserver.Server as safe as it was before but makes handlers run concurrently. Note, although most handlers run quickly, there is Delay option that sleeps in the handler when lock is acquired. With this change, sleep is done when lock is released.
This enables us to refactor acceptance test server to reuse single server rather than create a new listening socket & server per test, which adds more and more overhead as we add more tests.
This also enables more advanced usage of testserver.Server where handlers do more I/O.
Note, there is no consistent performance win or lose with the current test suite.
Tests
Ran test suite many times with hyperfine to ensure it's running stable.