Add metrics for compute type used#2879
Merged
andrewnester merged 5 commits intomainfrom May 14, 2025
Merged
Conversation
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
May 14, 2025
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
May 14, 2025
denik
reviewed
May 14, 2025
| if task.ExistingClusterId != "" { | ||
| hasClassicInteractiveCompute = true | ||
| continue | ||
| } |
denik
reviewed
May 14, 2025
| trace $CLI bundle deploy -t one | ||
| trace $CLI bundle deploy -t two | ||
| trace $CLI bundle deploy -t three | ||
| trace $CLI bundle deploy -t four |
Contributor
There was a problem hiding this comment.
The test was killed with timeout on CI: https://github.com/databricks/cli/actions/runs/15022764995/job/42215860250
You can raise timeout or break it into individual tests instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add metrics for compute type used
Why
This allows us to track which compute (serverless or classic and which type) is used in bundle tasks.
Tests
Added acceptance test