Conversation
anton-107
requested review from
andrewnester,
denik,
pietern and
shreyas-goenka
as code owners
denik
approved these changes
May 14, 2025
Contributor
denik
left a comment
denik
left a comment
There was a problem hiding this comment.
Thanks! Looks good, one comment about bundle.name.
anton-107
force-pushed
the
anton-107/acc-double-underscore
branch
from
347dfaa to
dea0049
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
denik
reviewed
May 15, 2025
| func (s *FakeWorkspace) JobsDelete(request jobs.DeleteJob) Response { | ||
| defer s.LockUnlock()() | ||
|
|
||
| delete(s.jobs, request.JobId) |
Contributor
There was a problem hiding this comment.
This could probably be replaced by MapDelete as well?
Contributor
Author
There was a problem hiding this comment.
func MapDelete[T any](w *FakeWorkspace, collection map[string]T, key string) Response
accepts map[string]T, while s.jobs is a map[int64]jobs.Job
Would you like to make MapDelete more generic?
Contributor
There was a problem hiding this comment.
Thanks, I did not realize it's a different key type.
Would you like to make MapDelete more generic?
Seems like a good idea, I don't see why not?
Contributor
Author
There was a problem hiding this comment.
Seems like a good idea, I don't see why not?
Done in the follow-up commit
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
anton-107
force-pushed
the
anton-107/acc-double-underscore
branch
from
dea0049 to
a19732d
Compare
denik
approved these changes
May 15, 2025
anton-107
force-pushed
the
anton-107/acc-double-underscore
branch
from
a19732d to
bf02126
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
One change in the series of changes for converting integration tests into acceptance tests.
This will allow for easier testing of various backing solutions for bundle deployment