testserver: log error on "method not allowed" same as "not found"#2933
Merged
testserver: log error on "method not allowed" same as "not found"#2933
Conversation
This is both informational and also prevents shipping tests that do not provide required handlers.
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
pietern
reviewed
May 23, 2025
| Response.Body = '{}' | ||
| # I'm adding 405 because that's what this test originally do. It's somewhat | ||
| # surprising though that CLI can receive 405 and that does not result in error anywhere. | ||
| Response.StatusCode = 405 |
Contributor
There was a problem hiding this comment.
Was this for testing only?
Contributor
Author
There was a problem hiding this comment.
No, this change is required to make this test pass. Otherwise that call is made and since there is no handler, you now get t.Error().
Contributor
There was a problem hiding this comment.
Got it -- so this still needs to be debugged in a follow-up.
@shreyas-goenka Could you figure out why this works when the backend returns a 405?
pietern
approved these changes
May 23, 2025
| Response.Body = '{}' | ||
| # I'm adding 405 because that's what this test originally do. It's somewhat | ||
| # surprising though that CLI can receive 405 and that does not result in error anywhere. | ||
| Response.StatusCode = 405 |
Contributor
There was a problem hiding this comment.
Got it -- so this still needs to be debugged in a follow-up.
@shreyas-goenka Could you figure out why this works when the backend returns a 405?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the diagnostics we have for 404 to 405 errors.
Today, if you call testserver and there is no path registered, you'll get 404 and a nice error message suggesting which setting to add to config. If you call some path that is present but does not have handler for the required method, you'll get 405 silently and without errors.
The deploy-artifact-path-type test had to be fixed since it relied on undefined handler before and now it fails.