Skip to content

Remove all server mocks from bundle/deploy/dashboard acceptance tests #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anton-107 merged 7 commits into from
Jun 13, 2025
Merged

Remove all server mocks from bundle/deploy/dashboard acceptance tests #3048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
51a7840
Add DELETE endpoint for lakeview dashboards in test server
anton-107 Jun 12, 2025
50d39f2
use generic MapDelete
anton-107 Jun 12, 2025
21d51bc
Change CREATE endpoint for Lakeview dashboards in test server to clos…
anton-107 Jun 12, 2025
68ea6dc
change bundle/generate/dashboard test to use DASHBOARD_ID instead of …
anton-107 Jun 12, 2025
32f8a1d
change bundle/generate/dashboard-inplace test to use DASHBOARD_ID ins…
anton-107 Jun 12, 2025
47ae587
Remove all server mocks from bundle/deploy/dashboard acceptance tests
anton-107 Jun 12, 2025
57e3248
Merge branch 'main' into anton-107/testserver-dashboard-removemocks
anton-107 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion acceptance/bundle/deploy/dashboard/nested-folders/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,15 @@ Deployment complete!
"lifecycle_state": "ACTIVE",
"parent_path": "/Users/[USERNAME]",
"path": "/Users/[USERNAME]/test bundle-deploy-dashboard [UUID].lvdash.json",
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Dashboard test bundle-deploy-dashboard\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}"
"serialized_dashboard": {
"pages": [
{
"name": "02724bf2",
"displayName": "Dashboard test bundle-deploy-dashboard",
"pageType": "PAGE_TYPE_CANVAS"
}
]
}
}

>>> [CLI] bundle destroy --auto-approve
Expand Down
3 changes: 1 addition & 2 deletions acceptance/bundle/deploy/dashboard/nested-folders/script
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
DASHBOARD_DISPLAY_NAME="test bundle-deploy-dashboard $(uuid)"
if [ -z "$CLOUD_ENV" ]; then
DASHBOARD_DISPLAY_NAME="test bundle/deploy/ 6260d50f-e8ff-4905-8f28-812345678903" # use hard-coded uuid when running locally
export TEST_DEFAULT_WAREHOUSE_ID="warehouse-1234"
Copy link
Copy Markdown
Contributor

@shreyas-goenka shreyas-goenka Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this, or can this also be removed?

fi

Expand All @@ -15,4 +14,4 @@ trap cleanup EXIT

trace $CLI bundle deploy
DASHBOARD_ID=$($CLI bundle summary --output json | jq -r '.resources.dashboards.dashboard1.id')
trace $CLI lakeview get $DASHBOARD_ID | jq '{lifecycle_state, parent_path, path, serialized_dashboard}'
trace $CLI lakeview get $DASHBOARD_ID | jq '{lifecycle_state, parent_path, path, serialized_dashboard: (.serialized_dashboard | fromjson | {pages: (.pages | map({name, displayName, pageType}))})}'
24 changes: 0 additions & 24 deletions acceptance/bundle/deploy/dashboard/nested-folders/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,3 @@ New = "[DASHBOARD_ID]"
# Windows:
Old = 'The system cannot find the file specified.'
New = 'no such file or directory'

[[Server]]
Pattern = "POST /api/2.0/lakeview/dashboards"
Response.Body = '''
{
"dashboard_id":"1234567890abcdef1234567890abcdef"
}
'''

[[Server]]
Pattern = "POST /api/2.0/lakeview/dashboards/{dashboard_id}/published"

[[Server]]
Pattern = "GET /api/2.0/lakeview/dashboards/{dashboard_id}"
Response.Body = '''
{
"dashboard_id":"1234567890abcdef1234567890abcdef",
"display_name": "test dashboard 6260d50f-e8ff-4905-8f28-812345678903",
"lifecycle_state": "ACTIVE",
"path": "/Users/[USERNAME]/test bundle-deploy-dashboard 6260d50f-e8ff-4905-8f28-812345678903.lvdash.json",
"parent_path": "/Users/tester@databricks.com",
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Dashboard test bundle-deploy-dashboard\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}"
}
'''
10 changes: 9 additions & 1 deletion acceptance/bundle/deploy/dashboard/simple_outside_bundle_root/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,15 @@ Deployment complete!
"lifecycle_state": "ACTIVE",
"parent_path": "/Users/[USERNAME]",
"path": "/Users/[USERNAME]/test bundle-deploy-dashboard [UUID].lvdash.json",
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Dashboard test bundle-deploy-dashboard\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}"
"serialized_dashboard": {
"pages": [
{
"name": "02724bf2",
"displayName": "Dashboard test bundle-deploy-dashboard",
"pageType": "PAGE_TYPE_CANVAS"
}
]
}
}

>>> [CLI] bundle destroy --auto-approve
Expand Down
3 changes: 1 addition & 2 deletions acceptance/bundle/deploy/dashboard/simple_outside_bundle_root/script
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
DASHBOARD_DISPLAY_NAME="test bundle-deploy-dashboard $(uuid)"
if [ -z "$CLOUD_ENV" ]; then
DASHBOARD_DISPLAY_NAME="test bundle/deploy/ 6260d50f-e8ff-4905-8f28-812345678903" # use hard-coded uuid when running locally
export TEST_DEFAULT_WAREHOUSE_ID="warehouse-1234"
fi
cp $TESTDIR/../simple/sample-dashboard.lvdash.json ../.
Expand All @@ -15,4 +14,4 @@ trap cleanup EXIT

trace $CLI bundle deploy
DASHBOARD_ID=$($CLI bundle summary --output json | jq -r '.resources.dashboards.dashboard1.id')
trace $CLI lakeview get $DASHBOARD_ID | jq '{lifecycle_state, parent_path, path, serialized_dashboard}'
trace $CLI lakeview get $DASHBOARD_ID | jq '{lifecycle_state, parent_path, path, serialized_dashboard: (.serialized_dashboard | fromjson | {pages: (.pages | map({name, displayName, pageType}))})}'
24 changes: 0 additions & 24 deletions acceptance/bundle/deploy/dashboard/simple_outside_bundle_root/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,3 @@ New = "[DASHBOARD_ID]"
# Windows:
Old = 'The system cannot find the file specified.'
New = 'no such file or directory'

[[Server]]
Pattern = "POST /api/2.0/lakeview/dashboards"
Response.Body = '''
{
"dashboard_id":"1234567890abcdef1234567890abcdef"
}
'''

[[Server]]
Pattern = "POST /api/2.0/lakeview/dashboards/{dashboard_id}/published"

[[Server]]
Pattern = "GET /api/2.0/lakeview/dashboards/{dashboard_id}"
Response.Body = '''
{
"dashboard_id":"1234567890abcdef1234567890abcdef",
"display_name": "test dashboard 6260d50f-e8ff-4905-8f28-812345678903",
"lifecycle_state": "ACTIVE",
"path": "/Users/[USERNAME]/test bundle-deploy-dashboard 6260d50f-e8ff-4905-8f28-812345678903.lvdash.json",
"parent_path": "/Users/tester@databricks.com",
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Dashboard test bundle-deploy-dashboard\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}"
}
'''
10 changes: 9 additions & 1 deletion acceptance/bundle/deploy/dashboard/simple_syncroot/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,15 @@ Deployment complete!
"lifecycle_state": "ACTIVE",
"parent_path": "/Users/[USERNAME]",
"path": "/Users/[USERNAME]/test bundle-deploy-dashboard [UUID].lvdash.json",
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Dashboard test bundle-deploy-dashboard\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}"
"serialized_dashboard": {
"pages": [
{
"name": "02724bf2",
"displayName": "Dashboard test bundle-deploy-dashboard",
"pageType": "PAGE_TYPE_CANVAS"
}
]
}
}

>>> [CLI] bundle destroy --auto-approve
Expand Down
3 changes: 1 addition & 2 deletions acceptance/bundle/deploy/dashboard/simple_syncroot/script
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
DASHBOARD_DISPLAY_NAME="test bundle-deploy-dashboard $(uuid)"
if [ -z "$CLOUD_ENV" ]; then
DASHBOARD_DISPLAY_NAME="test bundle/deploy/ 6260d50f-e8ff-4905-8f28-812345678903" # use hard-coded uuid when running locally
export TEST_DEFAULT_WAREHOUSE_ID="warehouse-1234"
fi
cp $TESTDIR/../simple/sample-dashboard.lvdash.json .
Expand All @@ -16,4 +15,4 @@ trap cleanup EXIT

trace $CLI bundle deploy
DASHBOARD_ID=$($CLI bundle summary --output json | jq -r '.resources.dashboards.dashboard1.id')
trace $CLI lakeview get $DASHBOARD_ID | jq '{lifecycle_state, parent_path, path, serialized_dashboard}'
trace $CLI lakeview get $DASHBOARD_ID | jq '{lifecycle_state, parent_path, path, serialized_dashboard: (.serialized_dashboard | fromjson | {pages: (.pages | map({name, displayName, pageType}))})}'
24 changes: 0 additions & 24 deletions acceptance/bundle/deploy/dashboard/simple_syncroot/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,3 @@ New = "[DASHBOARD_ID]"
# Windows:
Old = 'The system cannot find the file specified.'
New = 'no such file or directory'

[[Server]]
Pattern = "POST /api/2.0/lakeview/dashboards"
Response.Body = '''
{
"dashboard_id":"1234567890abcdef1234567890abcdef"
}
'''

[[Server]]
Pattern = "POST /api/2.0/lakeview/dashboards/{dashboard_id}/published"

[[Server]]
Pattern = "GET /api/2.0/lakeview/dashboards/{dashboard_id}"
Response.Body = '''
{
"dashboard_id":"1234567890abcdef1234567890abcdef",
"display_name": "test dashboard 6260d50f-e8ff-4905-8f28-812345678903",
"lifecycle_state": "ACTIVE",
"path": "/Users/[USERNAME]/test bundle-deploy-dashboard 6260d50f-e8ff-4905-8f28-812345678903.lvdash.json",
"parent_path": "/Users/tester@databricks.com",
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Dashboard test bundle-deploy-dashboard\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}"
}
'''
Loading