acc: Fix local inprocess tests when run from IDE#3056
Merged
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
| } | ||
|
|
||
| func testAccept(t *testing.T, inprocessMode bool, singleTest string) int { | ||
| // Load debug environment when debugging a single test run from an IDE. |
Contributor
There was a problem hiding this comment.
Can we keep it but under a flag? It's still valuable to have but by default can be turned off.
Contributor
Author
There was a problem hiding this comment.
I added it to TestInprocess as a comment 9b10702
Easy enough to uncomment if you need it.
Contributor
There was a problem hiding this comment.
The commented out code also works fine.
Contributor
There was a problem hiding this comment.
Is the comment at L52 still accurate (present in the original PR)?
Contributor
Author
There was a problem hiding this comment.
Partially, I moved it inside TestInprocess where other instruction is.
shreyas-goenka
approved these changes
Jun 13, 2025
denik
force-pushed
the
denik/acc-inprocess
branch
from
50f517a to
5a0663a
Compare
denik
force-pushed
the
denik/acc-inprocess
branch
from
2019076 to
ab3a5c1
Compare
andrewnester
approved these changes
Jun 23, 2025
- Do not load debug variables, this sets CLOUD_ENV which causes test runner to ignore local tests. Reverts #2765 - Better check in TestInprocess that test is actually run and not selected.
denik
force-pushed
the
denik/acc-inprocess
branch
from
8581ff6 to
b7833bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Loading those env vars sets CLOUD_ENV which makes test runner ignore local tests.
Tests
Manually. Set selftest/basic Cloud=false and run it via IDE.