Move generate utils to bundle/generate package
#3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
shreyas-goenka
approved these changes
Jun 19, 2025
Contributor
Author
|
Integration test failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
bundle/generate.Why
While looking into #2528, I wanted to add a unit test to the downloader and found it doesn't have any direct unit tests yet, and was colocated with the command implementations. This consolidates the downloader and the configuration conversion functions from
bundle/config/generateintobundle/generateand adds a simple unit test for the downloader. A follow-up PR will address path normalization.Tests
Unit tests pass.