-
Notifications
You must be signed in to change notification settings - Fork 125
acc: Fix dashboard/detect-change test #3149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It still fails with
- "url": "[DATABRICKS_URL]/dashboardsv3/[ALPHANUMID]/published",
+ "url": "[DATABRICKS_URL]/dashboardsv3/[ALPHANUMID]/published?o=[ALPHANUMID]",
On there other hand NUMBER replacement does not exist.
Follow up to #3144
denik
added a commit
that referenced
this pull request
Jul 1, 2025
Noticed in #3149 it is being referenced in places where it's not used.
Collaborator
93 failing tests:
|
Contributor
Author
|
Failure is unrelated: |
pietern
approved these changes
Jul 1, 2025
| [[Repls]] | ||
| # clean up ?o=<num> suffix after URL since not all workspaces have that | ||
| Old = '\?o=\[(NUMBER|NUMID)\]' | ||
| Old = '\?o=\[(NUMID|ALPHANUM)\]' |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why also ALPHANUM? Is this another precedence issue?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's regex overlap issue. Both match when id happens to be digits-only.
denik
added a commit
that referenced
this pull request
Jul 1, 2025
Noticed in #3149 it is being referenced in places where it's not used.
denik
added a commit
that referenced
this pull request
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still fails with
On there other hand NUMBER replacement does not exist.
Follow up to #3144