acc: Use more specific regex in default-python/combinations#3204
Merged
Conversation
This test uses regex to verify that if include_python is set to "yes" then we have a line like this:
+Uploading .databricks/bundle/dev/patched_wheels/python_artifact_x[UNIQUE_NAME]/x[UNIQUE_NAME]-0.0.1+[UNIX_TIME_NANOS]-py3-none-any.whl...
and if include_python is set to "no" then we don't have a line like that in the output.
However, we also always print a line like this:
Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/X[UNIQUE_NAME]/dev/files...
Since UNIQUE_NAME is random string, it sometimes contains "whl", causing regex to match where it should not.
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
Collaborator
83 failing tests:
|
andrewnester
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test uses regex to verify that if include_python is set to "yes" then we have a line like this:
and if include_python is set to "no" then we don't have a line like that in the output.
However, we also always print a line like this:
Since UNIQUE_NAME is random string, it sometimes contains "whl", causing regex to match where it should not.