Add template test to confirm the output when uv is not found#3240
Merged
Add template test to confirm the output when uv is not found#3240
Conversation
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
denik
reviewed
Jul 11, 2025
| cd output/fail_missing_uv | ||
| trace $CLI bundle validate | ||
|
|
||
| # Dynamically find the directory containing 'uv' and remove it from PATH |
Contributor
There was a problem hiding this comment.
can we do something simpler? would set PATH to empty string work?
Contributor
Author
There was a problem hiding this comment.
The command is executed via the shell and it still needs to find the shell.
Collaborator
16 failing tests:
|
denik
approved these changes
Jul 11, 2025
| # Dynamically find the directory containing 'uv' and remove it from PATH | ||
| uv_dir=$(dirname "$(command -v uv 2>/dev/null || which uv 2>/dev/null)") | ||
| if [ -n "$uv_dir" ]; then | ||
| export PATH=$(echo "$PATH" | tr ':' '\n' | grep -v "^$uv_dir$" | paste -sd: -) |
Contributor
There was a problem hiding this comment.
would prefer small Python script there as a more cross-platform and readable.
Contributor
Author
There was a problem hiding this comment.
Agree that would be more readable. This works now, though, and we don't have other call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We should provide installation instructions when uv is not found when we try to execute it. This test confirms the baseline to improve.