Skip to content

Validate enum values in DABs #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shreyas-goenka wants to merge 7 commits into from
Closed

Validate enum values in DABs #3279

shreyas-goenka wants to merge 7 commits into from

Conversation

@shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Jul 19, 2025 •
edited
Loading

Changes

Why

Tests

@shreyas-goenka shreyas-goenka changed the base branch from main to enum-values July 19, 2025 13:41
@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Jul 19, 2025 •
edited
Loading

Run: 16389302186

Env ✅‌pass 🔄‌flaky 🙈‌skip
✅‌ aws linux 305 428
✅‌ aws windows 306 427
🔄‌ aws-ucws linux 406 5 328
🔄‌ aws-ucws windows 408 4 327
✅‌ azure linux 305 427
✅‌ azure windows 306 426
🔄‌ azure-ucws linux 409 4 325
🔄‌ azure-ucws windows 411 3 324
✅‌ gcp linux 304 429
✅‌ gcp windows 305 428
6 failing tests:
Test Name aws-ucws linux aws-ucws windows azure-ucws linux azure-ucws windows
TestAccept ✅‌pass 🔄‌flaky 🔄‌flaky ✅‌pass
TestAccept/bundle/deploy/dashboard/simple_outside_bundle_root 🔄‌flaky ✅‌pass ✅‌pass 🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple_syncroot 🔄‌flaky ✅‌pass ✅‌pass 🔄‌flaky
TestAccept/bundle/deployment/bind/dashboard 🔄‌flaky 🔄‌flaky 🔄‌flaky ✅‌pass
TestAccept/bundle/deployment/bind/dashboard/recreation 🔄‌flaky 🔄‌flaky 🔄‌flaky ✅‌pass
TestDashboardAssumptions_WorkspaceImport 🔄‌flaky 🔄‌flaky 🔄‌flaky 🔄‌flaky

@shreyas-goenka shreyas-goenka mentioned this pull request Jul 21, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 22, 2025
@shreyas-goenka
Generate validation patterns for enums (#3277)
655c307 
## Changes
This PR generates a map containing a mapping of fields to their
acceptable values. A follow-up PR will use this map to perform actual
validation.

## Tests
Tested end to end validation using these patterns in:
#3279
@shreyas-goenka shreyas-goenka mentioned this pull request Jul 22, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 22, 2025
@shreyas-goenka
Add .Values method for enums in bundle config tree (#3278)
f2a357b 
## Why
These methods will be used in
#3279 to perform enum validation
for their respective fields.

## Tests
Generated enum_fields.go file has patterns necessary for validating the
fields.
Base automatically changed from enum-values to main July 22, 2025 18:21
@shreyas-goenka shreyas-goenka deleted the validate-enum branch July 25, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester will be requested when the pull request is marked ready for review andrewnester is a code owner

@anton-107 anton-107 Awaiting requested review from anton-107 anton-107 will be requested when the pull request is marked ready for review anton-107 is a code owner

@denik denik Awaiting requested review from denik denik will be requested when the pull request is marked ready for review denik is a code owner

@pietern pietern Awaiting requested review from pietern pietern will be requested when the pull request is marked ready for review pietern is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shreyas-goenka @eng-dev-ecosystem-bot