Skip to content

Move generated git annotations to sub-directories#3281

Merged
shreyas-goenka merged 7 commits intomainfrom
move-ag
Jul 22, 2025
Merged

Move generated git annotations to sub-directories#3281
shreyas-goenka merged 7 commits intomainfrom
move-ag

Conversation

@shreyas-goenka
Copy link
Copy Markdown
Contributor

@shreyas-goenka shreyas-goenka commented Jul 21, 2025

Why

These annotations no longer have to be regenerated during code generation.

Tests

Manually, by pushing a test commit and seeing the file diffs are not shown by default on Github.

Screenshot 2025-07-21 at 14 19 02

This reverts commit 197de8f.
Comment thread .codegen.json
"make schema",
"make generate-validation",
"echo 'bundle/internal/tf/schema/\\*.go linguist-generated=true' >> ./.gitattributes",
"echo 'go.sum linguist-generated=true' >> ./.gitattributes",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removing the annotations for go.sum because it's a small file so the diffs should not be too large.

@shreyas-goenka shreyas-goenka marked this pull request as ready for review July 21, 2025 12:24
@eng-dev-ecosystem-bot
Copy link
Copy Markdown
Collaborator

eng-dev-ecosystem-bot commented Jul 21, 2025

Run: 16416876920

Env ✅‌pass 🔄‌flaky 🙈‌skip
✅‌ aws linux 305 427
✅‌ aws windows 306 426
✅‌ aws-ucws linux 411 327
✅‌ aws-ucws windows 412 326
🔄‌ azure linux 303 2 426
✅‌ azure windows 306 425
✅‌ azure-ucws linux 413 324
✅‌ azure-ucws windows 414 323
✅‌ gcp linux 304 428
✅‌ gcp windows 305 427
Test Name azure linux
TestAccept 🔄‌flaky
TestAccept/bundle/templates/default-python/combinations/serverless 🔄‌flaky

@shreyas-goenka shreyas-goenka merged commit 2714127 into main Jul 22, 2025
12 of 13 checks passed
@shreyas-goenka shreyas-goenka deleted the move-ag branch July 22, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants