Extract deployPrepare() #3328
Merged
Extract deployPrepare() #3328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
commented
Jul 30, 2025
| }, | ||
| { | ||
| "key": "skip_artifact_cleanup", | ||
| "key": "python_wheel_wrapper_is_set", |
Contributor
Author
There was a problem hiding this comment.
I wonder why don't we use map[string]bool here, it would be more compact and not sensitive to order (since it's sorted on serialization). cc @shreyas-goenka
Collaborator
|
denik
force-pushed
the
denik/split-deploy-prepare
branch
from
2d71652 to
d9150a9
Compare
denik
force-pushed
the
denik/split-deploy-prepare
branch
from
d9150a9 to
1c70ed9
Compare
denik
force-pushed
the
denik/split-deploy-prepare
branch
from
1c70ed9 to
9a6696f
Compare
| // SwitchToPatchedWheels must be run after ExpandGlobReferences and after build phase because it Artifact.Source and Artifact.Patched populated | ||
| libraries.SwitchToPatchedWheels(), | ||
| libraries.Upload(), | ||
| trampoline.TransformWheelTask(), |
Contributor
There was a problem hiding this comment.
I think trampoline.TransformWheelTask() needs to be run after libraries.Upload because Upload mutates the config to have libraries point to uploaded location and transform needs to use this location
Contributor
Author
There was a problem hiding this comment.
Thanks, good catch. I have moved libraries.Upload() (and artifacts.CleanUp(), seems like it might be relevant as well) to their original place. This affects UX of "bundle plan" but that's ok at the moment, it's only internal command.
denik
force-pushed
the
denik/split-deploy-prepare
branch
from
543f7a1 to
eabe999
Compare
denik
changed the title
andrewnester
approved these changes
Jul 31, 2025
denik
added a commit
that referenced
this pull request
Jul 31, 2025
## Changes - Add "bundle plan" command that shows resource-level plan. It works for both TF and direct backend. - Make plan in direct deployment sort groups and resources so that output of "bundle plan" is consistent. Depends on #3328 ## Why Going to use this in acceptance tests to verify direct deployment. It'll be extended with an option to show field-level changes as well (most likely for direct deployment only). ## Tests Modified different acceptance tests to show different actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
No-op refactor to extract a set of mutators that are needed for "bundle plan".
Why
Going to use deployPrepare() in "bundle plan": #3329
It needs the same bundle config as bundle deploy in order to properly calculate plan.