Skip to content

direct: Support updating name and recreate for volumes #3342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
denik merged 1 commit into from
Aug 1, 2025
Merged

direct: Support updating name and recreate for volumes #3342

denik merged 1 commit into from
Aug 1, 2025

Conversation

@denik
Copy link
Contributor

@denik denik commented Aug 1, 2025 •
edited
Loading

Changes

  • Handle changing name of the volume via "new_name" field.
  • Fill in RecreateFields based on TF.

Tests

New acceptance tests.

@denik denik temporarily deployed to test-trigger-is August 1, 2025 11:10 — with GitHub Actions Inactive
Base automatically changed from denik/recreate-schemas to main August 1, 2025 11:22
@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Aug 1, 2025 •
edited
Loading

Run: 16674443009

Env ✅‌pass ❌‌FAIL 🔄‌flaky 🙈‌skip
✅‌ aws linux 308 457
🔄‌ aws windows 305 4 456
❌‌ aws-ucws linux 409 5 357
🔄‌ aws-ucws windows 410 5 356
✅‌ azure linux 308 456
🔄‌ azure windows 306 3 455
🔄‌ azure-ucws linux 410 6 354
🔄‌ azure-ucws windows 413 4 353
✅‌ gcp linux 307 458
🔄‌ gcp windows 305 3 457
12 failing tests:
Test Name aws windows aws-ucws linux aws-ucws windows azure windows azure-ucws linux azure-ucws windows gcp windows
TestAccept ✅‌pass ❌‌FAIL ✅‌pass 🔄‌flaky 🔄‌flaky ✅‌pass 🔄‌flaky
TestAccept/bundle/deploy/jobs/shared-root-path ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass ✅‌pass
TestAccept/bundle/deploy/jobs/shared-root-path/DATABRICKS_CLI_DEPLOYMENT=direct-exp ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass ✅‌pass
TestAccept/bundle/deploy/pipeline/allow-duplicate-names 🔄‌flaky ❌‌FAIL 🔄‌flaky ✅‌pass ✅‌pass 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/pipeline/allow-duplicate-names/DATABRICKS_CLI_DEPLOYMENT=direct-exp ✅‌pass ❌‌FAIL 🔄‌flaky ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky
TestAccept/bundle/deploy/pipeline/allow-duplicate-names/DATABRICKS_CLI_DEPLOYMENT=terraform 🔄‌flaky ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass
TestAccept/bundle/resources/pipelines/update ✅‌pass ❌‌FAIL ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/resources/pipelines/update/DATABRICKS_CLI_DEPLOYMENT=direct-exp ✅‌pass ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky 🔄‌flaky ✅‌pass
TestAccept/bundle/resources/pipelines/update/DATABRICKS_CLI_DEPLOYMENT=terraform ✅‌pass ❌‌FAIL ✅‌pass ✅‌pass 🔄‌flaky 🔄‌flaky ✅‌pass
TestAccept/selftest/record_cloud/basic 🔄‌flaky ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/selftest/record_cloud/basic/DATABRICKS_CLI_DEPLOYMENT=direct-exp ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/selftest/record_cloud/basic/DATABRICKS_CLI_DEPLOYMENT=terraform 🔄‌flaky ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass ✅‌pass ✅‌pass

@denik denik force-pushed the denik/recreate-volumes branch from 3783f3a to 89b1964 Compare August 1, 2025 11:56
@denik denik temporarily deployed to test-trigger-is August 1, 2025 11:56 — with GitHub Actions Inactive
@denik denik merged commit 4556111 into main Aug 1, 2025
12 of 13 checks passed
@denik denik deleted the denik/recreate-volumes branch August 1, 2025 12:44
@denik denik mentioned this pull request Aug 4, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 5, 2025
@denik
direct: volumes: fix updating the name (#3349)
1a7fe3f 
## Changes
- Add missing setting for volumes: UpdateUpdatesID. Without it, updating
the name fails with internal error.
- Update testserver to properly handle name updates.

## Why
Follow up to #3342

## Tests
New acceptance test.
alyssa-db pushed a commit that referenced this pull request Aug 7, 2025
@denik @alyssa-db
direct: volumes: fix updating the name (#3349)
9330c14 
## Changes
- Add missing setting for volumes: UpdateUpdatesID. Without it, updating
the name fails with internal error.
- Update testserver to properly handle name updates.

## Why
Follow up to #3342

## Tests
New acceptance test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anton-107 anton-107 anton-107 approved these changes

@pietern pietern Awaiting requested review from pietern pietern is a code owner

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@denik @eng-dev-ecosystem-bot @anton-107