Skip to content

fix: swapped output of symlink #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alyssa-db merged 8 commits into from
Aug 6, 2025
Merged

fix: swapped output of symlink #3361

alyssa-db merged 8 commits into from
Aug 6, 2025

Conversation

@alyssa-db
Copy link
Contributor

@alyssa-db alyssa-db commented Aug 5, 2025 •
edited
Loading

Changes

Bug fix: before, on installing pipelines for the first time, users are told that pipelines is reinstalled, while when overwriting their pipelines symlink, users are told pipelines is installed, without mention of the deletion.

Swapped output of print statements to match the actual expected output.

@alyssa-db alyssa-db force-pushed the install-pipelines-db-version-0 branch from 11ba036 to 8652a91 Compare August 5, 2025 20:45
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 5, 2025 20:45 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Aug 5, 2025 •
edited
Loading

Run: 16781365295

Env ✅‌pass 🔄‌flaky 🙈‌skip
🔄‌ aws linux 305 4 462
🔄‌ aws windows 307 3 461
✅‌ aws-ucws linux 415 362
✅‌ aws-ucws windows 416 361
🔄‌ azure linux 305 4 461
🔄‌ azure windows 299 11 460
🔄‌ azure-ucws linux 414 3 359
🔄‌ azure-ucws windows 416 2 358
✅‌ gcp linux 308 463
✅‌ gcp windows 309 462
20 failing tests:
Test Name aws linux aws windows azure linux azure windows azure-ucws linux azure-ucws windows
TestAccept ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple_outside_bundle_root ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/deploy/files/no-snapshot-sync ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/deploy/files/no-snapshot-sync/DATABRICKS_CLI_DEPLOYMENT=terraform ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/deploy/mlops-stacks ✅‌pass ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass
TestAccept/bundle/deployment/bind/dashboard/recreation ✅‌pass ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass
TestAccept/bundle/deployment/bind/volume 🙈‌skip 🙈‌skip 🙈‌skip 🙈‌skip 🔄‌flaky ✅‌pass
TestAccept/bundle/local_state_staleness ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/local_state_staleness/DATABRICKS_CLI_DEPLOYMENT=direct-exp ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/resources/pipelines/update 🔄‌flaky ✅‌pass 🔄‌flaky 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/resources/pipelines/update/DATABRICKS_CLI_DEPLOYMENT=direct-exp ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/resources/pipelines/update/DATABRICKS_CLI_DEPLOYMENT=terraform 🔄‌flaky ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass ✅‌pass
TestAccept/bundle/templates/default-python/combinations/classic ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_CLI_DEPLOYMENT=terraform/DLT=no/NBOOK=no/PY=no ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/templates/default-python/integration_classic 🔄‌flaky 🔄‌flaky ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=direct-exp/UV_PYTHON=3.10 ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass ✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=direct-exp/UV_PYTHON=3.11 🔄‌flaky ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass ✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=direct-exp/UV_PYTHON=3.9 ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass ✅‌pass ✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=terraform/UV_PYTHON=3.9 ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky ✅‌pass ✅‌pass
TestAccept/terraform ✅‌pass ✅‌pass ✅‌pass ✅‌pass ✅‌pass 🔄‌flaky

@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 5, 2025 23:06 — with GitHub Actions Inactive
jefferycheng1
jefferycheng1 approved these changes Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@jefferycheng1 jefferycheng1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you update the PR description to be more precise and update the nit

jefferycheng1
jefferycheng1 reviewed Aug 6, 2025
View reviewed changes
kanterov
kanterov approved these changes Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@kanterov kanterov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 to Jeffery feedback

@alyssa-db @jefferycheng1
Update cmd/pipelines/install_pipelines_cli.go
e4a797f 
Co-authored-by: Jeffery Cheng <105739315+jefferycheng1@users.noreply.github.com>
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 6, 2025 15:17 — with GitHub Actions Inactive
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 6, 2025 15:17 — with GitHub Actions Inactive
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 6, 2025 15:28 — with GitHub Actions Inactive
@alyssa-db alyssa-db enabled auto-merge August 6, 2025 15:28
@alyssa-db alyssa-db added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 04b9cdb Aug 6, 2025
13 checks passed
@alyssa-db alyssa-db deleted the install-pipelines-db-version-0 branch August 6, 2025 16:10
alyssa-db added a commit that referenced this pull request Aug 7, 2025
@alyssa-db @jefferycheng1
fix: swapped output of symlink (#3361)
e9b9a05 
## Changes
Bug fix: before, on installing pipelines for the first time, users are
told that pipelines is reinstalled, while when overwriting their
pipelines symlink, users are told pipelines is installed, without
mention of the deletion.

Swapped output of print statements to match the actual expected output.

---------

Co-authored-by: Jeffery Cheng <105739315+jefferycheng1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jefferycheng1 jefferycheng1 jefferycheng1 approved these changes

@kanterov kanterov kanterov approved these changes

@lennartkats-db lennartkats-db Awaiting requested review from lennartkats-db lennartkats-db is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alyssa-db @eng-dev-ecosystem-bot @kanterov @jefferycheng1