Skip to content

acc: add remote_field_storage_location test; improve testserver volumes #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
denik merged 12 commits into from
Aug 25, 2025
Merged

acc: add remote_field_storage_location test; improve testserver volumes #3474

denik merged 12 commits into from
Aug 25, 2025

Conversation

@denik
Copy link
Contributor

@denik denik commented Aug 25, 2025 •
edited
Loading

Changes

  • Update testserver volume to process storage_location like backend does on AWS.
  • Update acceptance test runner to treat Local more like AWS when it comes to CLOUD_ENV_BASE, so that tests can be run on both Local + Cloud
  • New test that sets storage_location to string and gets an error.
  • New test that sets storage_location to reference to another storage location and triggers "Provider produced inconsistent final plan" from terraform.

Why

New tests will be used for testing direct backend once it supports arbitrary $resources references.

@denik denik temporarily deployed to test-trigger-is August 25, 2025 12:38 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is August 25, 2025 12:44 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Aug 25, 2025 •
edited
Loading

Run: 17212010098

Env ✅‌pass 🙈‌skip
✅‌ aws linux 310 488
✅‌ aws windows 311 487
✅‌ aws-ucws linux 426 384
✅‌ aws-ucws windows 427 383
✅‌ azure linux 310 487
✅‌ azure windows 311 486
✅‌ azure-ucws linux 426 383
✅‌ azure-ucws windows 427 382
✅‌ gcp linux 309 489
✅‌ gcp windows 310 488

@denik denik temporarily deployed to test-trigger-is August 25, 2025 13:05 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is August 25, 2025 13:11 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is August 25, 2025 13:14 — with GitHub Actions Inactive
@denik denik changed the title acc: add remote_field_storage_location test acc: add remote_field_storage_location test; improve testserver volumes Aug 25, 2025
@denik denik temporarily deployed to test-trigger-is August 25, 2025 13:22 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is August 25, 2025 14:11 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is August 25, 2025 14:15 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is August 25, 2025 14:35 — with GitHub Actions Inactive
@denik denik added this pull request to the merge queue Aug 25, 2025
Merged via the queue into main with commit 0b84364 Aug 25, 2025
13 checks passed
@denik denik deleted the denik/remote_field_storage_location branch August 25, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewnester andrewnester andrewnester approved these changes

@pietern pietern Awaiting requested review from pietern pietern is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

@anton-107 anton-107 Awaiting requested review from anton-107 anton-107 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@denik @eng-dev-ecosystem-bot @andrewnester